Fix APM libraries crash (when present) by centralizing HTTPSession cleanup #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@pubnub-release-bot release as 9.3.3 |
jguz-pubnub
force-pushed
the
fix/apm-crash
branch
from
877fa2d to
b4dca27
Compare
jguz-pubnub
changed the title
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(presence): fix APM libraries crash (when present) by centralizing
HTTPSessioncleanupAPM libraries crash fix: Removed
deinitmethods that were callingsession.invalidateAndCancel()fromPresenceEffectFactoryandSubscribeEffectFactoryto prevent race conditions with Application Performance Monitoring libraries. Session cleanup now happens exclusively in HTTPSession.deinit, which ensures request cancellation before invalidation. This prevents crashes from occurring inside APM libraries when they intercept network operations during session invalidation.